[Bug 1284400] Review Request: koji-containerbuild - Koji support for building layered container images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1284400



--- Comment #2 from Adam Miller <admiller@xxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2.1 or later)", "Unknown or generated". 11 files have
     unknown license. Detailed output of licensecheck in
     /home/admiller/reviews/1284400-koji-containerbuild/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/koji-builder-plugins,
     /usr/lib/python2.7/site-packages/koji_containerbuild
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/koji-builder-plugins,
     /usr/lib/python2.7/site-packages/koji_containerbuild, /usr/lib/koji-
     hub-plugins
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in koji-
     containerbuild-hub , koji-containerbuild-builder , koji-
     containerbuild-cli
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %{!?python_sitelib: %define
     python_sitelib %(%{__python} -c "from distutils.sysconfig import
     get_python_lib; print get_python_lib()")}, %{!?python_sitelib: %define
     python_sitelib %(%{__python} -c "from distutils.sysconfig import
     get_python_lib; print get_python_lib()")}, %define module
     koji_containerbuild
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: koji-containerbuild-0.5.4-2.fc24.noarch.rpm
          koji-containerbuild-hub-0.5.4-2.fc24.noarch.rpm
          koji-containerbuild-builder-0.5.4-2.fc24.noarch.rpm
          koji-containerbuild-cli-0.5.4-2.fc24.noarch.rpm
          koji-containerbuild-0.5.4-2.fc24.src.rpm
koji-containerbuild.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-hub.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-hub.noarch: W: only-non-binary-in-usr-lib
koji-containerbuild-hub.noarch: W: no-documentation
koji-containerbuild-builder.noarch: W: spelling-error %description -l en_US
buildsystem -> build system, build-system, subsystem
koji-containerbuild-builder.noarch: E: description-line-too-long C Builder
plugin that extend Koji to communicate with OpenShift buildsystem and build
layered container images.
koji-containerbuild-builder.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-builder.noarch: W: only-non-binary-in-usr-lib
koji-containerbuild-builder.noarch: W: no-documentation
koji-containerbuild-cli.noarch: W: spelling-error %description -l en_US
buildsystem -> build system, build-system, subsystem
koji-containerbuild-cli.noarch: E: description-line-too-long C Builder plugin
that extend Koji to communicate with OpenShift buildsystem and build layered
container images.
koji-containerbuild-cli.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-cli.noarch: W: no-documentation
koji-containerbuild-cli.noarch: E: non-standard-executable-perm
/usr/bin/koji-containerbuild 775
koji-containerbuild-cli.noarch: W: no-manual-page-for-binary
koji-containerbuild
koji-containerbuild.src: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild.src:70: E: hardcoded-library-path in
%{_prefix}/lib/koji-hub-plugins
koji-containerbuild.src:71: E: hardcoded-library-path in
%{_prefix}/lib/koji-hub-plugins/hub_containerbuild.py
koji-containerbuild.src:72: E: hardcoded-library-path in
%{_prefix}/lib/koji-builder-plugins
koji-containerbuild.src:73: E: hardcoded-library-path in
%{_prefix}/lib/koji-builder-plugins/builder_containerbuild.py
koji-containerbuild.src:88: E: hardcoded-library-path in
%{_prefix}/lib/koji-hub-plugins/hub_containerbuild.py*
koji-containerbuild.src:92: E: hardcoded-library-path in
%{_prefix}/lib/koji-builder-plugins/builder_containerbuild.py*
koji-containerbuild.src: W: invalid-url Source0:
koji-containerbuild-0.5.4.tar.gz
5 packages and 0 specfiles checked; 9 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
koji-containerbuild-hub.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-hub.noarch: W: only-non-binary-in-usr-lib
koji-containerbuild-hub.noarch: W: no-documentation
koji-containerbuild-builder.noarch: E: description-line-too-long C Builder
plugin that extend Koji to communicate with OpenShift buildsystem and build
layered container images.
koji-containerbuild-builder.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-builder.noarch: W: only-non-binary-in-usr-lib
koji-containerbuild-builder.noarch: W: no-documentation
koji-containerbuild.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-cli.noarch: E: description-line-too-long C Builder plugin
that extend Koji to communicate with OpenShift buildsystem and build layered
container images.
koji-containerbuild-cli.noarch: W: invalid-url URL:
https://github.com/release-engineering/${name} HTTP Error 404: Not Found
koji-containerbuild-cli.noarch: W: no-documentation
koji-containerbuild-cli.noarch: E: non-standard-executable-perm
/usr/bin/koji-containerbuild 775
koji-containerbuild-cli.noarch: W: no-manual-page-for-binary
koji-containerbuild
4 packages and 0 specfiles checked; 3 errors, 10 warnings.



Diff spec file in url and in SRPM
---------------------------------
---
/home/admiller/reviews/1284400-koji-containerbuild/srpm/koji-containerbuild.spec
   2015-11-24 11:10:07.234422571 -0600
+++
/home/admiller/reviews/1284400-koji-containerbuild/srpm-unpacked/koji-containerbuild.spec
  2015-11-20 14:11:58.000000000 -0600
@@ -11,15 +11,5 @@

 License:        LGPLv2
-URL:            https://github.com/release-engineering/%{name}
-#Use the following commands to generate the tarball:
-#
-#    git clone --single-branch --branch koji-containerbuild-VERSION-RELEASE \
-#      https://github.com/release-engineering/koji-containerbuild.git && \
-#    cd ./koji-containerbuild && \
-#    python setup.py sdist
-#
-#Where:
-#- VERSION is version macro from specfile
-#- RELEASE is release macro from specfile and dist is not defined (empty)
+URL:            https://github.com/release-engineering/${name}
 Source0:        %{name}-%{version}.tar.gz
 BuildArch:      noarch
@@ -54,5 +44,5 @@

 %description builder
-Builder plugin that extend Koji to communicate with OpenShift build system and
build layered container images.
+Builder plugin that extend Koji to communicate with OpenShift buildsystem and
build layered container images.


@@ -63,5 +53,5 @@

 %description cli
-Builder plugin that extend Koji to communicate with OpenShift build system and
build layered container images.
+Builder plugin that extend Koji to communicate with OpenShift buildsystem and
build layered container images.

 %prep


Requires
--------
koji-containerbuild-hub (rpmlib, GLIBC filtered):
    koji-hub

koji-containerbuild-builder (rpmlib, GLIBC filtered):
    koji-builder
    osbs
    python-dockerfile-parse
    python-pycurl
    python-urlgrabber

koji-containerbuild (rpmlib, GLIBC filtered):
    koji
    python(abi)

koji-containerbuild-cli (rpmlib, GLIBC filtered):
    /usr/bin/env
    koji-builder



Provides
--------
koji-containerbuild-hub:
    koji-containerbuild-hub

koji-containerbuild-builder:
    koji-containerbuild-builder

koji-containerbuild:
    koji-containerbuild

koji-containerbuild-cli:
    koji-containerbuild-cli



Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1284400 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


Notes
-----

See areas marked [!] in above review template.

Please update to comply with Fedora Python Packaging Guidelines.
    https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]