https://bugzilla.redhat.com/show_bug.cgi?id=1284989 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11969289 Some initial comments: Naming: ok License: ok Scriptlets: ok Sources: mostly ok (see item 3 below) 228fff5975a61872b83052be97e2eabf 1.2.10.tar.gz 1. SHOULD use %{qmake_qt4} macro in favor of %{_qt4_qmake}, the former sets flags automatically for you, so you can avoid manually setting stuff like: QMAKE_CFLAGS_RELEASE="%{optflags}" QMAKE_CXXFLAGS_RELEASE="%{optflags}" 2. MUST document why you're not using %{?_smp_mflags} 3. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags for better-named source tarballs, in particular, please consider using: Source0: https://github.com/mumble-voip/mumble/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz 4. SHOULD use unambiguous build deps, in particular use: BuildRequires: qt4-devel or BuildRequires: pkgconfig(QtGui) in favor of BuildRequires: qt-devel 5. SHOULD drop some deprecated rpm tags, including: Group: 6. SHOULD consider dropping -protocol subpkg, it's there only for one file, and arguably for something a bit deprecated (no recent fedora release ships a kde4 desktop, nor is a single .protocol file by itself particularly useful) 7. MUST document the need for these explicit runtime dependencies: Requires: celt071, speex, opus (at least some of these should already be handled via implicit rpm library autodepends) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review