https://bugzilla.redhat.com/show_bug.cgi?id=1282091 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |piotr1212@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |piotr1212@xxxxxxxxx Flags| |fedora-review- --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- Looks good, except of the license: As this is MIT licensed, license text is missing and upstream is not responsive you must add a license text yourself, see: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text "Fedora Packagers must either: Include a copy of what they believe the license text is intended to be, as part of the Fedora package in %license, in order to remain in compliance." Rest of package looks fine (you could delete mocha in test section) I'll approve as soon as you add a license text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review