https://bugzilla.redhat.com/show_bug.cgi?id=1200038 --- Comment #5 from Sanne Wouda <snnw@xxxxxxxxxxxxxx> --- Thanks for the comments, Terje. (In reply to Terje Røsten from comment #4) > Some quick comments. > > - BuildRoot: ..., %clean section, line %defattr(-,root,root,-) and line rm > -rf $RPM_BUILD_ROOT in %install are not needed, remove these Removed the mentioned lines and sections. Thanks. > - Use %license macro COPYING is the license and has been marked as such. > - Lines in %%description too long The line was 79 characters long exactly, but I've made it shorter anyway. > - Drop disttag from changelog, use: 1.9-1 > This way you can use same spec file for all branches. Nice. > - Add empty line between each changelog item. Done. Is this a convention, or requirement? New links: Spec: http://www.stack.nl/~snnw/generic-colouriser.spec SRPM: http://www.stack.nl/~snnw/generic-colouriser-1.9-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review