https://bugzilla.redhat.com/show_bug.cgi?id=1246904 --- Comment #15 from Jens Lody <fedora@xxxxxxxxxxx> --- (In reply to Jerry James from comment #14) > This is a very clean package. I only see two issues, both extremely minor: > - The %configure macro already includes --prefix=%{_prefix}, so supplying it > again is redundant (but not harmful); see the definition of %configure in > /usr/lib/rpm/redhat/macros. I will remove it before importing. > - There is no %check script (this is a SHOULD, not a MUST). > I don't know if it would be possible, or how difficult it would be to create meaningful tests. > I won't delay the package for either, so this package is APPROVED. Fix > either or both of those issues when you import the package, at your > discretion. Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review