https://bugzilla.redhat.com/show_bug.cgi?id=1202063 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #17 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- FESCo voted to allow anybody to do initial reviews, seperately from the sponsorship process [https://fedorahosted.org/fesco/ticket/1499]. I'll take this review. - suggestion: put BuildRequires each on a separate line, this makes it easier to spot mistakes. - suggestion: add empty lines before %description, before %changelog, before %files. - suggestion: use "%make_install INSTALL_ROOT=%{buildroot}" for the make line (shorter is better). - suggestion: use '.*' instead of '.gz' for the man pages. This will avoid issues if the compression ever changes. - You should use %find_lang macro instead of explicitly listing files. See https://fedoraproject.org/wiki/PackagingDrafts/find_lang. - DISPLAY= classified-ads dumps core :( (Not a packaging issue, just pointing it out.) classified-ads.src: W: file-size-mismatch classified-ads-0.09.tar.gz = 2287384, https://github.com/operatornormal/classified-ads/archive/0.09.tar.gz#/classified-ads-0.09.tar.gz = 2288561 3 packages and 0 specfiles checked; 0 errors, 1 warnings. So... no major issues. Please update the tarball and maybe fix the other things. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review