https://bugzilla.redhat.com/show_bug.cgi?id=1275386 --- Comment #2 from Martin Preisler <mpreisle@xxxxxxxxxx> --- Spec URL: https://mpreisle.fedorapeople.org/pkgs/openscap-daemon/openscap-daemon.spec SRPM URL: https://mpreisle.fedorapeople.org/pkgs/openscap-daemon/openscap-daemon-0.1.0-2.fc22.src.rpm Thanks for review, comments inline. (In reply to Šimon Lukašík from comment #1) > 1) The package should require dbus package as it uses /etc/dbus-1/system.d/ > directory. > > This is not a blocker, as you already require python-dbus. But still > consider fixing this. Done > > 2) First paragraph of description is not really a project description. > > However, this is not a blocker. https://github.com/OpenSCAP/openscap-daemon/issues/29 > > 3) The whole thing is python2. > > There is no problem with that, per se. We can accept Python2 packages to > Fedora. So the packaging is alright. > > However, atomic in F23+ is build/installed using python3 and you require > some of the atomic parts. > That could will not work on F23, so you need to patch the specfile for f23 > and rawhide. > > Please review the specfile of atomic, and consider using same if/else > statements for deciding target python version. Currently only python2 is supported. This may be revisited in the future. > > 2) rpmlint issues: > > openscap-daemon.noarch: W: invalid-license LGPLv2.1+ > > Please fix this. The document at > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing advices to use > LGPLv2+ in your case. Done > Also there are files in `cve_scanner` sub-dir which are LGPLv2+. Note that > FSF address is incorrect in them (not a blocker). https://github.com/OpenSCAP/openscap-daemon/issues/28 > > > openscap-daemon.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/org.oscapd.conf > > Use %config(noreplace) %{_sysconfdir}/dbus-1/system.d/ ... Done > > > openscap-daemon.noarch: W: no-manual-page-for-binary oscapd > > openscap-daemon.noarch: W: no-manual-page-for-binary oscapd-cli > > This is not a blocker for me. However, perhaps you can file an upstream > ticket for this. https://github.com/OpenSCAP/openscap-daemon/issues/27 > > > openscap-daemon.src: W: invalid-url Source0: https://github.com/OpenSCAP/openscap-daemon/releases/download/0.1.0/openscap_daemon-0.1.0.tar.gz HTTP Error 403: Forbidden > > Please use valid URL. It is actually a valid URL and can be downloaded with firefox or chrome just fine. I suspect github is returning 403 based on sent user-agent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review