[Bug 1282903] Review Request: golang-github-sallyom-Register - Golang binary for registering OCI containers with systemd-machined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #5 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Patch:
- updated commit to the latest on (git commit --amend has changed the hash)
- updated ExclusiveArch tag
- removed unnecessary commented commands
- added LICENSE under %license tag
- wrapped BR of the main package with "with_bundled" macro (BR is not needed if
the package is built from bundled deps)
- add unit-test-devel subpackage, disable check and unit-test as there are no
tests atm

Summary(after applying the patch):
- devel subpackage presented (even if one file, it contains a dependency on
dbus which is discovered during scan and used when building dependency graph
for all golang projects packaged in Fedora)
- unit-test-devel subpackage presented (usefull for CI testing, atm there are
no test files. However, it is better to disable generating the unit-test-devel
subpackage (and enable it later) than to remove it.
- license ok
- complete list of build-time dependencies
- debuginfo genereated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]