https://bugzilla.redhat.com/show_bug.cgi?id=1279175 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx QA Contact|extras-qa@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, As discussed by email I will review this and sponsor you as a Fedora packager when the review is done. This is not yet a full review, but the result of a quick scan, which shows several issues: 1) Starting with the generic upstream spec file is fine but please drop: 1a) All the %if 0%{?suse_version} blocks (keeping the non suse code) 1b) The Group: and BuildRoot: lines we no longer use those 2) I do not think that keeping upstream's changelog in the spec file is is useful, please drop it and replace it with one with a single entry with you as author saying something like: -Initial Fedora package based on upstream spec-file for 1.5-1 And make the release of the new version 2, so that your package version is 1.5-2, in Fedora we always bump the release field during reviews (and make changelog entries for any improvements) so that reviewers can easily track changes made during the review process. 3) rpmlint rpmbuild/SRPMS/innoextract-1.5-1.fc23.src.rpm rpmbuild/RPMS/x86_64/* results in : innoextract.src: W: strange-permission innoextract-1.5.tar.gz 640 innoextract.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 54) innoextract.src: W: file-size-mismatch innoextract-1.5.tar.gz = 178011, http://constexpr.org/innoextract/files/innoextract-1.5.tar.gz = 179582 3 packages and 0 specfiles checked; 0 errors, 3 warnings. The first message can be ignored, the second one needs to be fixed (please uses spaces everywhere) the third one is weird, please double check your sources match upstream. Doing a diff on the 2 different tarbals unpacked says: Only in innoextract-1.5.src.rpm: .mailmap Only in innoextract-1.5.src.rpm: .travis.yml So maybe upstream has respun the tarbal to remove these 2 unwanted files ? Thanks & Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review