[Bug 1282917] Review Request: perl-Test-mysqld - Mysqld runner for tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1282917



--- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-mysqld-0.17-1.fc24.noarch.rpm | sort | uniq -c
      1 mysql-server
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Class::Accessor::Lite)
      1 perl(Cwd)
      1 perl(DBD::mysql)
      1 perl(DBI)
      1 perl(File::Copy::Recursive)
      1 perl(File::Temp)
      1 perl(POSIX)
      1 perl(Time::HiRes)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Add run Requires
- perl(File::Spec) - Test-mysqld-0.17/lib/Test/mysqld.pm:183
- perl(File::Basename) - Test-mysqld-0.17/lib/Test/mysqld.pm:184

$ rpm -qp --provides perl-Test-mysqld-0.17-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Test::mysqld) = 0.17
      1 perl-Test-mysqld = 0.17-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Test-mysqld*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires:
FIX: Please remove from BRs
- perl(Config) - Module::Install::Can not used for build
- perl(Fnctl) - Module::Install::Makefile not used for build

Please correct all 'FIX' issues and provide new spec file.

Otherwise the package looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]