https://bugzilla.redhat.com/show_bug.cgi?id=1282903 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(somalley@redhat.c | |om) --- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- Hi Sally, can you regenerate the spec file with the latest build for f23 [1]?. I have built it today. It contains some updates of generated spec file, making the spec file more clean. Karmas on it would be appreciated [2]. 'gofed repo2spec --detect https://github.com/sallyom/Register --commit 79c22398b30da927f4fd58aa45b5155bd859d34e --with-build' will do the magic. In general: - it is always good to provide devel subpackage so other can import your source codes. Even if the current devel subpackage would be empty, it is scanned by other tools. - any [Build]Required golang package should be a virtual provide, not physical one, i.e. use golang(github.com/godbus/dbus) instead of golang-github-godbus-dbus-devel. In future the name of the golang-github-godbus-dbus package can change. Virtual provides does not change unless the imported package is removed. Can you provide LICENSE file for https://github.com/sallyom/Register? Without that the package can not be packaged in Fedora. [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=700023 [2] https://bodhi.fedoraproject.org/updates/FEDORA-2015-bd2922d501 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review