[Bug 1282914] Review Request: perl-Lingua-Translit - Transliterates text between writing systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1282914

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jplesnik@xxxxxxxxxx



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Lingua-Translit-0.22-1.fc24.noarch.rpm | sort | uniq
-c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Carp)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(Getopt::Long)
      1 perl(Lingua::Translit)
      1 perl(Lingua::Translit::Tables)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-Lingua-Translit-0.22-1.fc24.noarch.rpm | sort | uniq
-c
      1 perl(Lingua::Translit) = 0.22
      1 perl(Lingua::Translit::Tables) = 0.10
      1 perl-Lingua-Translit = 0.22-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Lingua-Translit*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires
FIX: Please add BRs:
- perl(Exporter) - Lingua-Translit-0.22/lib/Lingua/Translit/Tables.pm - line 74
- perl(utf8) - Lingua-Translit-0.22/lib/Lingua/Translit/Tables.pm - line 12
  and tests
- make - spec file - line 38, 44, 52
- coreutils - spec file - line 46, 47, 56
- findutils - spec file - line 46, 47

FIX: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
  %install.
TODO: Remove the deleting empty directories in %install section. This is
  default behavior.


Please correct all 'FIX' issues and consider fixing 'TODO' items and provide
new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]