https://bugzilla.redhat.com/show_bug.cgi?id=1234654 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|williamjmorenor@xxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- There are issues that have to be fixed: - %{?python_provide:%python_provide python2-%{srcname}} is duplicated on line 22. It should only be present on line 33. - python2-gammu contains %{python3_sitearch}/gammu. This does not look right. - python2_sitearch should be used instead of python_sitearch. ===== Notes ===== Upgrade path looks ok because python-gammu-2.4 is older than python-gammu-1.35 built from gammu. License is OK, license file is present, %license macro is used. New python packaging template is used. Latest version is present. Upstream and source links are OK. Description and summary are OK. Rpmlint ------- Checking: python2-gammu-2.4-1.fc24.x86_64.rpm python3-gammu-2.4-1.fc24.x86_64.rpm python-gammu-2.4-1.fc24.src.rpm python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/worker.cpython-35.opt-1.pyc False positive. python2-gammu.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gammu/_gammu.so 775 python2-gammu.x86_64: E: non-standard-executable-perm /usr/lib64/python3.5/site-packages/gammu/_gammu.cpython-35m-x86_64-linux-gnu.so 775 python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/smsd.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/data.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/exception.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/__init__.cpython-35.opt-1.pyc python3-gammu.x86_64: W: only-non-binary-in-usr-lib 3 packages and 0 specfiles checked; 2 errors, 6 warnings. Nothing interesting here. Rpmlint (debuginfo) ------------------- Checking: python-gammu-debuginfo-2.4-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python3-gammu.x86_64: W: only-non-binary-in-usr-lib python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/smsd.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/worker.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/__init__.cpython-35.opt-1.pyc python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/data.cpython-35.opt-1.pyc python2-gammu.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gammu/_gammu.so 775 python2-gammu.x86_64: W: python-bytecode-without-source /usr/lib64/python3.5/site-packages/gammu/__pycache__/exception.cpython-35.opt-1.pyc python2-gammu.x86_64: E: non-standard-executable-perm /usr/lib64/python3.5/site-packages/gammu/_gammu.cpython-35m-x86_64-linux-gnu.so 775 3 packages and 0 specfiles checked; 2 errors, 6 warnings. All OK. Requires -------- python3-gammu (rpmlib, GLIBC filtered): python2-gammu (rpmlib, GLIBC filtered): libGammu.so.7()(64bit) libc.so.6()(64bit) libgsmsd.so.7()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libpython3.5m.so.1.0()(64bit) <-------------------------------------- not ok python(abi) rtld(GNU_HASH) Provides -------- python3-gammu: python3-gammu python3-gammu(x86-64) python2-gammu: python-gammu python-gammu(x86-64) python2-gammu python2-gammu(x86-64) Unversioned so-files -------------------- python2-gammu: /usr/lib64/python2.7/site-packages/gammu/_gammu.so python2-gammu: /usr/lib64/python3.5/site-packages/gammu/_gammu.cpython-35m-x86_64-linux-gnu.so OK. Source checksums ---------------- https://github.com/gammu/python-gammu/archive/2.4.tar.gz#/python-gammu-2.4.tar.gz : CHECKSUM(SHA256) this package : 106e769604a5d68622d1cbbc79690222493d643ba4f8f2198f521901299cf6f2 CHECKSUM(SHA256) upstream package : 106e769604a5d68622d1cbbc79690222493d643ba4f8f2198f521901299cf6f2 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1234654 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review