https://bugzilla.redhat.com/show_bug.cgi?id=1273579 --- Comment #8 from Raphael Groner <projects.rg@xxxxxxxx> --- For a first step, I found some general advices to your spec file. MUST: - Add full URL to Source0, it's not sufficient to mention in comment only. I guess you use the snapshot tarball of GitHub, then please follow the official recommendation to do so. Alternatively, you have to specify in a comment how to create the tarball (with an included script in SRPM?). https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services - Did you send the patches to upstream? Please make notes in comments or use the direct URLs. https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines https://fedoraproject.org/wiki/Staying_close_to_upstream_projects#Why_push_changes_upstream.3F - Some lines in %description seem to be too long. Please restructure this block. The same counts also for the subpackages analogously. - Usage of %global is preferred over %define, please explain why this does not apply here. https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - The common subpackage does not contain the license file, please add it to satisfy all other subpackages with that license too through the specified dependencies. The doc subpackage needs also the license file. - Use the new %python_provide placeholder, the Provides are somehow wrong when we follow the new guidelines. https://fedoraproject.org/wiki/Packaging:Python#Provides - The subpackages have to own also the individually created sub folders, besides the files itself. https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_wholly_contained_in_your_package.2C_or_involves_core_functionality_of_your_package - Specification of doc subpackage is not allowed as such. It's needed to list all folders and files individually, of course wildcards are possible. Remove %doc when you directly use installed pathes. https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation SHOULD: - You can use pushd/popd instead of cd commands to get the path changes logged. http://www.eriwen.com/bash/pushd-and-popd/ - Use "cp -p" to preserve timestamps. - Please try harder to disable the check of automake, it's better with a special patch (maybe applied in epel7 only but you do not need this build conditional here at all), instead of this ugly sed command that is going to break in future when the line numbers change. https://fedoraproject.org/wiki/Packaging:Guidelines#Applying_patches - You can use the new macros %make_build and %make_install that set default parameters. - Please rename the subpackages as suggested in the example template: python2-nest, python2-nest-openmpi and python2-nest-mpich https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file - Please ask upstream about future plans to support Python3. https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support That's it for now. When the above hints are fixed, I can take a deeper look. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review