Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 orion@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 | nThis| | Flag|fedora-review- |fedora-review+ ------- Additional Comments From orion@xxxxxxxxxxxxx 2007-06-12 16:41 EST ------- Looks good to me. I would change: %{_bindir}/* %{python_sitelib}/* %{_datadir}/applications/* to: %{_bindir}/kodos %{_python_sitelib}/kodos/ %{_datadir}/applications/fedora-kodos.desktop because personally I like to list things out. Helps detect when things change. But I'll leave that up to your preference. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review