https://bugzilla.redhat.com/show_bug.cgi?id=1275009 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review- --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- Thanks for packaging. This needs some work before I can approve: - License: should be BSD, not GPL, it also seems that there are more license files, please check if this is multi-licensed and set correct licenses - URL: Please set correct url which points to the actual package - BuildRequires, I expect there are some deps missing, at least grunt-cli - %prep, use "cp -p" to preserve timestamps - %build, package needs to be build with "grunt" - Please add %check section with tests - %install, nothing is being installed - %changelog, incorrect version 1.0.0 instead of 1.1.1 If you need help/clarification on some items let me know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review