https://bugzilla.redhat.com/show_bug.cgi?id=1281315 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Package naming - This is tough one with regards to naming. The name according to naming guidelines should be "rubygem-rubygems-mirror". I personally would be fine with the shortened "rubygems-mirror", because this code actually used to be part of RUbyGems code base, priori it was extracted into RubyGems plugin and independent package. Nevertheless, after discussion with other packages, it seems that general consensus prefers consistency, i.e. the "rubygem-rubygems-mirror" name. Could you please rename the package? - Please also note that optionally, you could add: Provides: rubygems-mirror virtual provide into your package, so either rubygems-mirror or rubygem-rubygems-mirror will be installable in case of confusion. * Non-executable script - rpmlint complains about non-executable script: rubygems-mirror-doc.noarch: E: non-executable-script \ /usr/share/gems/gems/rubygems-mirror-1.1.0/Rakefile 644 /usr/bin/env - I'd suggest to drop the shebang from the Rakefile using something like: sed -i '/^#!\/usr\/bin\/env/ d' %{buildroot}%{gem_instdir}/Rakefile - Would be nice to suggest this change to upstream, since shebang in Rakefile is meaningless * Dot files removal - This is minor nit, but you can probably remove all the dot files by single sweep, e.g. you could use: %exclude %{gem_instdir}/.* * Separate license file - It would be nice to ask upstream to include license file [1]. Otherwise the package looks good. Please rename the package so I can approve it and sponsor you. [1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#cite_note-24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review