https://bugzilla.redhat.com/show_bug.cgi?id=1281245 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --provides perl-DBIx-Class-DeploymentHandler-0.002218-1.fc24.noarch.rpm | sort | uniq -c 1 perl(DBIx::Class::DeploymentHandler) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::Dad) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator::Deprecated) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator::ScriptHelpers) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::Deprecated) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::HandlesDeploy) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::HandlesVersionStorage) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::HandlesVersioning) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::LogImporter) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::LogRouter) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::Logger) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::Types) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionHandler::DatabaseToSchemaVersions) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionHandler::ExplicitVersions) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionHandler::Monotonic) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::Component) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResult) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResultSet) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::Component) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResult) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResultSet) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::WithApplicatorDumple) = 0.002218 1 perl(DBIx::Class::DeploymentHandler::WithReasonableDefaults) = 0.002218 1 perl-DBIx-Class-DeploymentHandler = 0.002218-1.fc24 Binary provides are Ok. $ rpm -qp --requires perl-DBIx-Class-DeploymentHandler-0.002218-1.fc24.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Carp::Clan) 1 perl(Context::Preserve) 1 perl(DBIx::Class::Core) 1 perl(DBIx::Class::DeploymentHandler::LogImporter) 1 perl(DBIx::Class::DeploymentHandler::LogRouter) 1 perl(DBIx::Class::DeploymentHandler::Logger) 1 perl(DBIx::Class::DeploymentHandler::Types) 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResult) 1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResult) 1 perl(DBIx::Class::ResultSet) 1 perl(DBIx::Class::Schema) 1 perl(DBIx::Class::Storage) 1 perl(File::Spec::Functions) 1 perl(List::Util) 1 perl(Log::Contextual) 1 perl(Log::Contextual::WarnLogger) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moose) 1 perl(Moose::Role) 1 perl(Moose::Util) 1 perl(Moose::Util::TypeConstraints) 1 perl(MooseX::Role::Parameterized) 1 perl(Path::Class) 1 perl(SQL::Translator) 1 perl(SQL::Translator::Diff) 1 perl(Sub::Exporter::Progressive) 1 perl(Text::Brew) 1 perl(Time::HiRes) 1 perl(Try::Tiny) 1 perl(autodie) 1 perl(namespace::autoclean) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add run requires: - perl(Log::Contextual::Role::Router) - lib/DBIx/Class/DeploymentHandler/LogRouter.pm:6 - perl(DBIx::Class::Schema::Loader) - lib/DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator/ScriptHelpers.pm:58 $ rpmlint ./perl-DBIx-Class-DeploymentHandler* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires are almost ok FIX: Please add constrain to perl(Test::Pod) >= 1.41 Please correct all 'FIX' issues. Otherwise the package looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review