https://bugzilla.redhat.com/show_bug.cgi?id=1267189 --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- No new packages can be added to F21, so you can remove the part "%if 0%{?fedora} <= 22". %autosetup would probably be better than multiple %patch invocations... I'd also make the desktop and appdata files separate in dist-git. Just a preference of course, but you could e.g. point upstream to the file in dist-git then, and it would be easier to follow or reuse just that file. rpmlint complains: antimony.x86_64: E: non-standard-executable-perm /usr/bin/antimony 775 Would be nice to fix that. The provides are borked: there's no python3-fab in the automatically generated Provides. Why don't you split out the python module as a separate package? That would be nice if it can be used separately. Looks all good otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review