https://bugzilla.redhat.com/show_bug.cgi?id=1265628 --- Comment #22 from Pavel Šimerda (pavlix) <psimerda@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #12) > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/libexec/dhcpcd-hooks > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/libexec/dhcpcd-hooks It's now in %files. > [!]: Package contains systemd file(s) if in need. Added a dhcpcd.service. > [!]: %check is present and all tests pass. Added %check. > Checking: dhcpcd-6.9.3-2.fc24.i686.rpm > dhcpcd-6.9.3-2.fc24.src.rpm > dhcpcd.i686: W: spelling-error Summary(en_US) minimalistic -> minimalist, > minimalism, animistic > dhcpcd.i686: W: spelling-error Summary(en_US) rdisc -> disc, r disc > dhcpcd.i686: W: spelling-error %description -l en_US minimalistic -> > minimalist, minimalism, animistic Looks ok. > dhcpcd.i686: W: unstripped-binary-or-object /usr/sbin/dhcpcd Shouldn't that be handled automatically by the debuginfo logic? > dhcpcd.i686: E: non-standard-executable-perm /usr/libexec/dhcpcd-run-hooks > 555 > dhcpcd.i686: E: non-standard-executable-perm /usr/sbin/dhcpcd 555 Fixed by BINDIR variable assignment. > dhcpcd.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, > minimalism, animistic > dhcpcd.src: W: spelling-error Summary(en_US) rdisc -> disc, r disc > dhcpcd.src: W: spelling-error %description -l en_US minimalistic -> > minimalist, minimalism, animistic Looks ok. > dhcpcd.src: W: no-%build-section Fixed. > Well, > > 1. Checking for libudev ... no > Checking for ntpd ... not found > Checking for ypbind ... not found I see. Well, we need some dependencies. > i. Systemd dev packages required. > > ---Attention--- > > 1. Make sure you have correct systemd scriptlets, it's important. > > 2. Make sure you have elegant systemd unit files, means it doesn't hurt user > experience during upgrade. Done. > 3. Make sure you have units for all interfaces / single interface, this > means you need to create dhcpcd.service and dhcpcd@.service. I'm now only interested in dhcpcd.service for now. Let's talk about it later. > ii. Also consider adding ntp hook. Possibly. > 2. Where is build section? Fixed. > 3. EPEL7 doesn't requires Group tag. Removed. > 4. dhcpcd.i686: E: non-standard-executable-perm > /usr/libexec/dhcpcd-run-hooks 555 > dhcpcd.i686: E: non-standard-executable-perm /usr/sbin/dhcpcd 555 > > Why not 755? Lying in /sbin doesn't mean 555 is OK. Fixed. > 5. Haven't specify dbdir in %configure, if you insist on keeping the default > path, then include it in %files, by %ghost, %dir (mkdir in %install, then > include it in %files, or other ways you like) I don't insist on it. Fixed. > 6. `make test` please. Fixed. > 7. %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig > > You are confusing yourself, ldconfig shouldn't be called because dhcpcd > doesn't have libraries. Fixed. > 8. You need to make sure ipv4all and duid are disabled, for reasons behind: > > i. 0conf sucks > > ii. DHCP Unique Identifier sucks in many environments which don't have ipv6 > enabled. Let's discuss the details after the review with a wider group of participants, especially maintainers of the existing DHCP packages in Fedora. > 9. /etc -> %{_sysconfdir} in %files. Fixed. > Just out of curiosity, have you ever used it? From the spec I couldn't > parse, too opaque. ;) I'm using dhcpcd both for testing local DHCP configuration and on some Gentoo hosts as a network configurator. My motivation to add it to Fedora is... https://fedoraproject.org/wiki/QA/Networking I need something that can easily test IPv4/IPv6 autoconfiguration and also provide a simple alternative to NetworkManager for testing scenarios as well as an alternative implementation to be compared to. I just talked to the upstream developer and he's working on dhcpcd-online working just like nm-online or systemd-networkd-wait-online. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review