[Bug 1189375] Review Request:nodejs-btoa - conversion from base64-encoded to ascii

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1189375



--- Comment #4 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
some issues:

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- nodejs-btoa.noarch: W: only-non-binary-in-usr-lib
  nodejs-btoa.noarch: E: non-executable-script
/usr/lib/node_modules/nodejs-btoa/bin/btoa.js 644 /usr/bin/env

- Please use github source guidelines for source0 or use npm.

- any particular reason for disabling the tests? All tests succeed here

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]