https://bugzilla.redhat.com/show_bug.cgi?id=1280141 --- Comment #1 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- Before I will do full review fix major issues: psychopy/LICENSES.txt. You should unbundle those. For ttf - patch to use system -------------------------------------------------------------------------------- - pyparallel (http://pyserial.sourceforge.net/pyparallel.html). License: Python Software Foundation - quest (http://www.visionegg.org/Quest). License: BSD - psychopy/app/Resources/DejaVuSerif.ttf. License: BSD-like (see below for full list of terms) -------------------------------------------------------------------------------- I don't see any adventures why you packaging latest commit. It's not acceptable without good reason because since last release was only 44 commits. -------------------------------------------------------------------------------- Source0: https://github.com/psychopy/psychopy/archive/%{commit}/%{modname}-%{shortcommit}.tar.gz -------------------------------------------------------------------------------- You don't have any BuildRequires/Requires for this package. I opened only one file and already see dependency on wxPython. https://github.com/psychopy/psychopy/blob/master/psychopy/app/_psychopyApp.py >From .travis.yml I see at least pygame, gevent, psutil, msgpack, pandas and many others. This wildcard I think not good, because I guess there only 1 directory. -------------------------------------------------------------------------------- %{python2_sitelib}/%{modname}* -------------------------------------------------------------------------------- If you're using version you should use macros! But I'd recommend to use %{python2_sitelib}/PsychoPy*.egg-info -------------------------------------------------------------------------------- %{python2_sitelib}/PsychoPy-1.83.1-py2.7.egg-info/* -------------------------------------------------------------------------------- Changelog for sure incorrect. Release is incorrect (you must bump version and use 0.1.git...., but don't do this and stick to release). And last BIG issue: You DONT run tests. You MUST. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review