https://bugzilla.redhat.com/show_bug.cgi?id=1279650 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Text-Brew-0.02-2.fc24.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Exporter) 1 perl(constant) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Text-Brew-0.02-2.fc24.noarch.rpm | sort | uniq -c 1 perl(Text::Brew) = 0.02 1 perl-Text-Brew = 0.02-2.fc24 Binary provides are Ok. $ rpmlint ./perl-Text-Brew* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires FIX: Please add following BRs - make - used in spec file - perl(warnings) - lib/Text/Brew.pm:4, Makefile.PL:2 FIX: Remove perl(Exporter), it is listed twice. TODO: Please sort the list of BRs. Please correct all 'FIX' issues and consider fixing 'TODO' item Otherwise package looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review