https://bugzilla.redhat.com/show_bug.cgi?id=1277966 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- NON blocking issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 50 files have unknown license. Detailed output of licensecheck in /home/gil/1277966-R-crayon/licensecheck.txt Please, report to upstream and ask to add license headers in those files where is missing https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define packname crayon Please, fix before import approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review