[Bug 1277956] Review Request: R-digest - Create Cryptographic Hash Digest of R Objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1277956



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "zlib/libpng",
     "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)",
     "BSD (2 clause)". 28 files have unknown license. Detailed output of
     licensecheck in /home/gil/1277956-R-digest/licensecheck.txt

BSD (2 clause)
--------------
digest/digest/src/xxhash.c
digest/digest/src/xxhash.h
xxHash is available here https://github.com/Cyan4973/xxHash

BSD (3 clause)
--------------
digest/digest/src/sha2.c
digest/digest/src/sha2.h

GPL (v2 or later)
-----------------
digest/digest/R/digest.R
digest/digest/inst/include/pmurhashAPI.h
digest/digest/src/digest.c
digest/digest/src/init.c

GPL (v2 or later) (with incorrect FSF address)
----------------------------------------------
digest/digest/src/aes.c
digest/digest/src/sha256.c

Please, report to upstream
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

MIT see https://code.google.com/p/smhasher/
----------------------------------------------
digest/digest/src/pmurhash.c
digest/digest/src/pmurhash.h

zlib/libpng
-----------
digest/digest/src/crc32.c
digest/digest/src/zconf.h
digest/digest/src/zlib.h
digest/digest/src/zutil.h

Unknown or generated
--------------------
digest/digest/ChangeLog
digest/digest/DESCRIPTION
digest/digest/MD5
digest/digest/NAMESPACE
digest/digest/R/AES.R
digest/digest/R/hmac.R
digest/digest/README.md
digest/digest/cleanup
digest/digest/inst/GPL-2
digest/digest/man/AES.Rd
digest/digest/man/digest.Rd
digest/digest/man/hmac.Rd
digest/digest/src/aes.h
digest/digest/src/crc32.h
digest/digest/src/md5.c
digest/digest/src/md5.h
digest/digest/src/raes.c
digest/digest/src/sha1.c
digest/digest/src/sha1.h
digest/digest/src/sha256.h
digest/digest/tests/AESTest.R
digest/digest/tests/AESTest.Rout.save
digest/digest/tests/digestTest.R
digest/digest/tests/digestTest.Rout.save
digest/digest/tests/hmacTest.R
digest/digest/tests/hmacTest.Rout.save

Please, report to upstream and ask to add license headers in those files where
is missing
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

Please, change license field in GPLv2 and BSD and MIT and zlib
and add Provides: bundle(foo)

[!]: Package contains no bundled libraries without FPC exception.

[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define packname digest

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]