https://bugzilla.redhat.com/show_bug.cgi?id=1279100 Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> --- (In reply to Jan Pazdziora from comment #3) > (In reply to Patrick Uiterwijk from comment #2) > > Package Review > > Thanks for the review and sorry for not catching them myself. No problem at all, that's why we do reviews. > > I've now uploaded updated > https://adelton.fedorapeople.org/mod_auth_openidc.spec and also new > .src.rpm: > https://adelton.fedorapeople.org/mod_auth_openidc-1.8.6-0.9.fc23.src.rpm. > > > - %build honors applicable compiler flags or justifies otherwise. > > %optflags is not used > > My hope is that %configure takes care of this. After checking, I saw that you are correct in this. > > - Package has no %clean section with rm -rf %{buildroot} > > %clean is present. Is not needed with RHEL>=6 or Fedora>=!EOL > > - %check is present and all tests pass. > > No %check present. %check with "make test" should do the trick. > > Removed. %clean is gone now yes, I still don't see a %check. It would be great if you could add %check, as that would also help koschei builds be more useful. Other then that, the package is good. So: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review