https://bugzilla.redhat.com/show_bug.cgi?id=1279100 Jan Pazdziora <jpazdziora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpazdziora@xxxxxxxxxx --- Comment #3 from Jan Pazdziora <jpazdziora@xxxxxxxxxx> --- (In reply to Patrick Uiterwijk from comment #2) > Package Review Thanks for the review and sorry for not catching them myself. I've now uploaded updated https://adelton.fedorapeople.org/mod_auth_openidc.spec and also new .src.rpm: https://adelton.fedorapeople.org/mod_auth_openidc-1.8.6-0.9.fc23.src.rpm. > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file LICENSE.txt is marked as %doc instead of %license Fixed. > - %build honors applicable compiler flags or justifies otherwise. > %optflags is not used My hope is that %configure takes care of this. > - Spec file is legible and written in American English. > Would be nice to have the BuildRequires split over several lines > for readability Changed. > - Uses parallel make %{?_smp_mflags} macro. > %{_smp_mflags} not used Fixed. > - Package has no %clean section with rm -rf %{buildroot} > %clean is present. Is not needed with RHEL>=6 or Fedora>=!EOL > - %check is present and all tests pass. > No %check present. %check with "make test" should do the trick. Removed. > mod_auth_openidc.x86_64: E: summary-too-long C Authentication/Authorization > module for the Apache 2.x HTTP server that allows users to authenticate > using an OpenID Connect enabled Identity Provider > mod_auth_openidc.x86_64: E: description-line-too-long C This module enables > an Apache 2.x web server to operate as an OpenID Connect Relying Party > and/or OAuth 2.0 Resource Server. Fixed. > mod_auth_openidc.x86_64: W: incoherent-version-in-changelog 1.8.6-1 > ['1.8.6-0.7.fc21', '1.8.6-0.7'] The final release number will be -1. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review