[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1276880



--- Comment #1 from Julien Enselme <jujens@xxxxxxxxx> ---
Hi,

Before doing the review, I have some remarks.

- The default executable should now be in the python3 subpackage. See
https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin

- Using %{py3dir} is deprecated. Please use the new method to build python2 and
python3 in a separate dir:
https://fedoraproject.org/wiki/Packaging:Python_Appendix#Using_separate_build_directories

- Please remove bundled lib in mne/externals (you can assign me to the
unpackaged ones and I will review them):
  - Already packaged: tempita, six, decorator
  - Not packaged yet: h5io (https://github.com/h5io/h5io), jdcal
(https://pypi.python.org/pypi/jdcal/1.0), FieldTrip (if you manage to find it,
otherwise I think we can safely ignore this. I guess that this is linked to
http://www.fieldtriptoolbox.org/development/integrate_with_mne but I was not
able to find a directly accessible tarball).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]