https://bugzilla.redhat.com/show_bug.cgi?id=1276837 --- Comment #3 from Julien Enselme <jujens@xxxxxxxxx> --- Hi, Before doing a full review of this package, I have some questions/remarks: - I think the initial release tag is incorrect and should be 0.1.git%{shortcommit}%{?dist} instead of 0.0.git%{shortcommit}%{?dist} (so the current release tag should be 0.2.git%{shortcommit}%{?dist}) See https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages - Please add %license pydicom/license.txt to all subpackage to install the license file where it is expected to be. - According to the license file, some part of the software are bundled with pydicom and distributed under a different license: > Portions of pydicom (private dictionary file(s)) were generated from the private dictionary of the GDCM library, released under the following license: > Program: GDCM (Grassroots DICOM). A DICOM library > Module: http://gdcm.sourceforge.net/Copyright.html However, I don't know which files this relates to. Do you have more information on that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review