https://bugzilla.redhat.com/show_bug.cgi?id=1278960 --- Comment #4 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- (In reply to Tom Hughes from comment #3) > So per > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text I > think %license should only be used for files that only contain the license. Makes sense. I've fixed this in the latest version. > As lib/heap.js is built from src/heap.coffee we should probably run coffee > in %build to recreate it. Good call. I've fixed this as well. > The other issue is the comment that the tests are disabled (they're not) > along with the patch that is being applied to them without any explanation > and which doesn't seem to be needed as it builds OK without it on F22, F23 > and Rawhide. Long story short -- I needed this patch for a newer version of the "should" module that I was playing with in one of my repos -- but you're right, it's not needed here. Fixed. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-heap/nodejs-heap.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-heap/nodejs-heap-0.2.6-4.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review