Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: elilo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225724 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium dcantrell@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dcantrell@xxxxxxxxxx Flag| |needinfo?(clumens@xxxxxxxxxx | |) ------- Additional Comments From dcantrell@xxxxxxxxxx 2007-06-11 13:40 EST ------- W: elilo no-url-tag W: elilo unversioned-explicit-obsoletes eli W: elilo buildprereq-use gnu-efi, pciutils-devel Source and patch file references should %{name} and %{version} (except patches). Copying of docs in %build should preserve everything (-a). If possible, pass the %{?_smp_mflags} to make in the %build section. If the make can be paralle for a package, it should be. In the %install section, use path macros when appropriate (e.g., macros for /usr/share, /usr/share/man, /usr/sbin, and so on). %defattr in %files should be %defattr(-,root,root,-) /usr/sbin in %files section should be referenced with %{_sbindir} Personal opinion: %{buildroot} looks nicer than $RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review