https://bugzilla.redhat.com/show_bug.cgi?id=1276831 --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review! (In reply to gil cattaneo from comment #5) > ISSUES: > > [!]: Package contains no static executables. Okay, those are removed in the next version. > [!]: Uses parallel make %{?_smp_mflags} macro. > make manual ? I can do this if you insist, but it won't do any good. Building the manual is an inherently sequential process, so only 1 submake will run at a time anyway. > [!]: License file installed when any subpackage combination is installed. > Should be installed also in the libs sub package Note that -libs depends on the -tex subpackage, which contains the license. No matter which package you install, the -tex subpackage gets pulled in, so the license is always installed. > Should be contact upstream yo inclide license headers where missing, and > also for upgrade license test file with new Free Software Foundation address > > tth-tex.noarch: E: incorrect-fsf-address /usr/share/licenses/tth-tex/GPL2.txt Okay, I will tell upstream. (In reply to gil cattaneo from comment #6) > forgotten > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tth-tex > , tth-libs , tth-devel , tth-debuginfo > > tth-devel sub package should provide > > Requires: %{name}-libs%{?_isa} = %{version}-%{release} Good catch. I have fixed this in the new version as well. New URLs: Spec URL: https://jjames.fedorapeople.org/tth/tth.spec SRPM URL: https://jjames.fedorapeople.org/tth/tth-4.08-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review