Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gengetopt - Tool to write command line option parsing code for C programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243607 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-11 11:13 EST ------- Created an attachment (id=156723) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156723&action=view) mock build log of gengetopt 2.19.1-2 on F-devel i386 * About %{_datadir}/%{name} - Well, according to the explanation by upstream on the URL above, it may well that all files under %{_datadir}/%{name} be moved into main package and nuke -devel subpackage? * make check - This package contains tests/ subdirectory and "make check" seems to do some tests. So IMO adding the following is recommended. ----------------------------------------------------------- %check make check ----------------------------------------------------------- Also, mock build says: ----------------------------------------------------------- checking for source-highlight... no checking for gengen... no checking for valgrind... no checking for help2man... no ----------------------------------------------------------- While I don't know about source-highlight and gengen, valgrind and help2man is in Fedora and with these, "make check" seems to do some more additional tests. So IMO you should add "valgrind help2man" to BuildRequires if you want to activate checking. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review