[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #24 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #22)
> Regarding patches.
> 1 and 2 just disables downloading and using external python-compyte (and
> upstream don't want to change this. it was discussed in upstream
> python-compyte). Third is just to fix CFLAGS.

As I stated in the review comment, comments need adding to the spec file
explaining this.

You should also add a comment with the license bug url above the license tag.

You haven't added any of the bundled Provides that I helpfully worked out for
you in the review comment.

You haven't added a %check section and added the tests during build that I
pointed out.

At this point I stopped checking the rest of the issues.

Basically, it seems like you've totally ignored the issues I raised during
review :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]