[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #7 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Julien Enselme from comment #6)
> Some remarks:
> 
> - Version of so files looks incorrect: /usr/lib64/libccnet.so.0.0.0,
> /usr/lib64/libccnet.so.0 Shouldn't this be /usr/lib64/libccnet.so.4.3.4 and
> /usr/lib64/libccnet.so.4?

No. Library version numbers and package version numbers actually are not
connected at all (cf. info libtool). 

So, even though using "0.0.0" is likely to bug upstream and Fedora at some time
in future (e.g. when upstream changes the API/ABI), using "0.0.0" is
technically correct.


Additional remark:
I'd recommend to change Source0 into this:
Source0:       
https://github.com/haiwen/%{name}/archive/v%{version}.tar.gz#/ccnet-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]