https://bugzilla.redhat.com/show_bug.cgi?id=1277100 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256:1a38d62365ded89315568a80c31f5bf77f1330bf20463ce11a35a6489a6abdc4). Ok. Summary verified from lib/Cache/LRU.pm. Ok. Description verified from lib/Cache/LRU.pm. Ok. TODO: Capitalize the "perl" word in the summary and the description. It's used as a name of the programming language. License verified from README, lib/Cache/LRU.pm. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require `perl(Test::Requires)'. It's not used anywhere. All tests pass. Ok. $ rpmlint perl-Cache-LRU.spec ../SRPMS/perl-Cache-LRU-0.04-1.fc24.src.rpm ../RPMS/noarch/perl-Cache-LRU-0.04-1.fc24.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Cache-LRU-0.04-1.fc24.noarch.rpm drwxr-xr-x 2 root root 0 Nov 2 15:08 /usr/share/doc/perl-Cache-LRU -rw-r--r-- 1 root root 296 Apr 7 2014 /usr/share/doc/perl-Cache-LRU/Changes -rw-r--r-- 1 root root 1293 Nov 2 15:08 /usr/share/doc/perl-Cache-LRU/README -rw-r--r-- 1 root root 1779 Nov 2 15:08 /usr/share/man/man3/Cache::LRU.3pm.gz drwxr-xr-x 2 root root 0 Nov 2 15:08 /usr/share/perl5/vendor_perl/Cache -rw-r--r-- 1 root root 3277 Apr 7 2014 /usr/share/perl5/vendor_perl/Cache/LRU.pm File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Cache-LRU-0.04-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(:VERSION) >= 5.8.0 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Cache-LRU-0.04-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(Cache::LRU) = 0.04 1 perl-Cache-LRU = 0.04-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Cache-LRU-0.04-1.fc24.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=11672345). Ok. Othwerwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items and consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review