Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Slony-1 (postgresql-slony-engine) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199154 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2007-06-10 17:40 EST ------- Hello, (In reply to comment #14) > This package needs some major cleanup. I'll do a full review soon, Thanks -- and please let's wait until 1.2.10, which will have some more improvements in the spec file. > but first a few remarks: > - Adding postgresql-server and autoconf to the BuildRequires fixes a few > errors during mockbuild. Uh, thanks... > why are you running autoconf after configure? :-) It will disappear as of 1.2.10. The spec file I am currently using is the one that is used to build RPMs from CVS -- so autoconf is required there. As of 1.2.10, there will be two spec files in the Slony-I tarball, and one of them will be for Fedora packaging. > I attached a patch which fixes building the docs as well. Thanks. I also committed these changes to the spec file in Slony-I CVS. I updated the spec file and SRPM at my website in order not to lose work: New spec: http://developer.postgresql.org/~devrim/rpms/other/slony1/postgresql-slony1-engine.spec SRPM: http://developer.postgresql.org/~devrim/rpms/other/slony1/postgresql-slony1-engine-1.2.9-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review