[Bug 1275391] Review Request: wbar - A quick launch bar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1275391



--- Comment #5 from William Moreno <williamjmorenor@xxxxxxxxx> ---
Are you going to epel5? If not, there is no need of rm -rf $RPM_BUILD_ROOT in
%%install.

Note than the current spec build fine in epel6, epel7 and current Fedora:
http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131391/

Where is the license file? You must use the %license macro to handle the
COPYING file in the tarball. Note than for epel6 you need to define the
%license macro in %%files with 

%files 
%{!?_licensedir:%global license %%doc}
%license COPYING

Where are the docs files? You must use the %doc macro to handle the AUTHORS
ChangeLog INSTALL README NEWS THANKS and TODO files in the tarball.

Consider to create a -docs subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]