https://bugzilla.redhat.com/show_bug.cgi?id=1276161 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort | uniq -c 1 /usr/bin/env 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Class::Accessor::Fast) 1 perl(Getopt::Long) 1 perl(List::MoreUtils) 1 perl(Pod::Usage) 1 perl(Regexp::Common) 1 perl(SQL::SplitStatement) 1 perl(SQL::Tokenizer) >= 0.22 1 perl(base) 1 perl(constant) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort | uniq -c 1 perl(SQL::SplitStatement) = 1.00020 1 perl-SQL-SplitStatement = 1.00020-2.fc24 Binary provides are Ok. $ rpmlint perl-SQL-SplitStatement* perl-SQL-SplitStatement.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-SQL-SplitStatement/LICENSE 2 packages and 1 specfiles checked; 1 errors, 0 warnings. Invalid address was reported to upstream. Otherwise rpmlint is ok. BuildRequires need to be updated FIX: Please add BRs * perl(base) - lib/SQL/SplitStatement.pm:10 * perl(File::Find) - SQL-SplitStatement-2.00020/t/00-compile.t:10 * perl(strict) - Makefile.PL and tests * perl(warnings) - Makefile.PL and tests * Add version constrain to perl(SQL::Tokenizer) >= 0.22 Description TODO: this part of Description should be changed "(for the details see the "SUPPORTED DBMSs" section below)", because the section is part of man page not Description Please correct all 'FIX' issues and consider fixing 'TODO' item Otherwise, the package looks good Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review