https://bugzilla.redhat.com/show_bug.cgi?id=1264546 --- Comment #47 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- Hi Gustavo, While most times the warnings about spelling errors are pointless, there are these: %description flow-module-form This package contains the form flow module for %{name}. The modul eprovides nodes producing formatted, string output to feed LCD "modul" above is a typo, broke line at wrong position. ... %description pin-mux-module-galileo This package contains the galileo pin-mux module for %{name}. The module provides pin multiplexing rules/mapping for Galileo boards (revisions D ang G). Without this module, to use Galileo I/O pins with "ang" above should be "and"? -----8<----- The code in sol_memmap_write_raw_do still looks wrong. On little endian it will only work if reading 8 bytes, or, if initializing old_value to zero, and reading from 0 to 8 bytes. On big endian would work only if reading 8 bytes. If entry->size is larger than 8 bytes, it will trash the stack. The warning about result possibly not initialized in src/modules/flow/boolean/boolean.c appears sensible, as there is a code path where it can be used uninitialized, so, it should be safe to initialize it to zero. But you should know better :) -----8<----- About the version, It should be fine as you are upstream and also submitting the review, and increasing the beta number every review. Otherwise, it is common practice to add a "0.1" and increase it, to avoid the case of renaming the word "beta" in a way that would appear to be older. As long as you pay attention to rpmdev-vercmp it should be fine. You should notice any issues when making a test update package, *but*, sometimes it may be too late, as the package was already released, and then need to use the Epoch rpm tag to fix the mess :) -----8<----- I think we are almost done with the review. I would like to have an extra comment about my question about if you have an ETA for a stable release. For safety, in case you choose to call the first official release 0.0.1 it would be better to change back to Release: 0.1.%{soletta_tag}%{?dist} - but really, pre releases are avoided as official packages :) Not only for this reason, but due to not having a somewhat long lived, common release, so that people talk about the same thing :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review