Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grig - a Ham Radio Control graphical user interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222533 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmahut@xxxxxxxxxx ------- Additional Comments From mmahut@xxxxxxxxxx 2007-06-10 12:18 EST ------- REVIEW ======== + source files match upstream. c83fd4b8b32ca84a4021e8afad6f9b64 grig-0.7.2.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. + license is open source-compatible. + license text included in package. + latest version is being packaged. + BuildRequires are proper. + %clean is present. + no scriptlets required. + package installs properly. + rpmlint is silent. + only code, not content. - *.desktop file looks proper. category X-Fedora is obselete + documentation is small -- no -docs subpackage is necessary. Everything except this .desktop file is fine, please change it before posting to cvs. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review