https://bugzilla.redhat.com/show_bug.cgi?id=1268090 Randy Barlow <rbarlow@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbarlow@xxxxxxxxxx --- Comment #1 from Randy Barlow <rbarlow@xxxxxxxxxx> --- Hi William! I am also seeking to become a maintainer, so this review is informal only. Here are a few notes that I have for you: 0) It is conventional to name Python 2 packages with a python- prefix and Python 3 packages with a python3- prefix, but this package uses python2- instead of python. You will probably be required to fix that. 1) Is this package only intended to support EPEL >= 7 and Fedora? If so that is fine but if not you may need some macros to make sure the Python 3 blocks only execute on systems that support Python 3. 2) You've repeated the description three times. I believe it is possible to only write it once at the top, since the two packages share the same description. I believe this holds for the summary as well. 3) You've commented out the lines in your check section. You probably should include those lines unless the tests don't pass in the upstream project. If they do not pass, I recommend removing the commented code for cleanliness. 4) Sometimes the information provided in the egg.info files can be important for certain packages, particularly if Python entry points are used. You may want to leave that in instead of removing it, but it depends on the package. Looks good, good luck! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review