[Bug 1272652] Review Request: tktable - Table/matrix widget extension to Tcl/Tk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1272652



--- Comment #10 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Jerry James from comment #9)
> Here is a modified %check script that fails if any tests fail:
> 
> %check
> %if 0%{?rhel} && 0%{?rhel} < 6
> Xvfb :1 &
> export DISPLAY=:1
> make test 2>&1 | tee test.log
> killall Xvfb
> %else
> xvfb-run -a make test 2>&1 | tee test.log
> %endif
> grep -E 'Failed[[:blank:]]+0' test.log > /dev/null
> 
> The actual test failure appears to be due to a changed error message in
> newer versions of tk; see the output of "strings %{_libdir}/libtk.so".  That
> shouldn't cause the test to fail, so I think you should simply do something
> like this on the affected Fedora releases:
> 
> sed -e 's/\(bad relief\) type/\1/' -i tests/tkTable.test

Great!

Spec URL: https://sagitter.fedorapeople.org/tktable/tktable.spec
SRPM URL: https://sagitter.fedorapeople.org/tktable/tktable-2.10-7.fc22.src.rpm

- tkTable.test adjusted according to the error message in newer versions of tk
(bz#1272652#c9)
- Making 'Make' sensitive to failed tests (bz#1272652#c9)

Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11597224
Epel5 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11597379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]