[Bug 1275438] Review Request: xindy - Index generator for structured documents like LaTeX or SGML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1275438

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #2 from Christopher Meng <i@xxxxxxxx> ---
Your spec doesn't match the Fedora standard:

0. Please use full brackets:

%{buildroot}, not %buildroot, also, 
1. make -j1

Reason?

2. clisp sucks on ARM.

3. 
make install DESTDIR="%buildroot";
rm -f "%buildroot/%_prefix/VERSION";

";" means nothing here, not sure why you added it.

4. %clean is not needed, and Group as well.

5. You don't need to put your long name or email address on the top to show
it's something from you, we all know it's a "spec file for package xindy" from
its Name. Your email will be showned at %changelog section.

6. Invalid changelog, please read guideline to see how to write good changelog.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]