https://bugzilla.redhat.com/show_bug.cgi?id=1265628 --- Comment #12 from Christopher Meng <i@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Public domain", "BSD (3 clause)", "BSD (2 clause) ISC", "ISC", "BSD (2 clause)". 30 files have unknown license. Detailed output of licensecheck: *No copyright* Public domain ---------------------------- dhcpcd-6.9.3/crypt/md5.c dhcpcd-6.9.3/crypt/md5.h BSD (2 clause) -------------- dhcpcd-6.9.3/arp.c dhcpcd-6.9.3/arp.h dhcpcd-6.9.3/auth.c dhcpcd-6.9.3/auth.h dhcpcd-6.9.3/common.c dhcpcd-6.9.3/common.h dhcpcd-6.9.3/compat/arc4random.h dhcpcd-6.9.3/compat/arc4random_uniform.h dhcpcd-6.9.3/compat/closefrom.c dhcpcd-6.9.3/compat/closefrom.h dhcpcd-6.9.3/compat/dprintf.c dhcpcd-6.9.3/compat/dprintf.h dhcpcd-6.9.3/compat/endian.h dhcpcd-6.9.3/compat/getline.c dhcpcd-6.9.3/compat/getline.h dhcpcd-6.9.3/compat/posix_spawn.c dhcpcd-6.9.3/compat/posix_spawn.h dhcpcd-6.9.3/compat/strlcpy.c dhcpcd-6.9.3/compat/strlcpy.h dhcpcd-6.9.3/compat/strtoi.c dhcpcd-6.9.3/compat/strtoi.h dhcpcd-6.9.3/control.c dhcpcd-6.9.3/control.h dhcpcd-6.9.3/crypt/crypt.h dhcpcd-6.9.3/crypt/hmac_md5.c dhcpcd-6.9.3/crypt/sha256.c dhcpcd-6.9.3/crypt/sha256.h dhcpcd-6.9.3/defs.h dhcpcd-6.9.3/dev.c dhcpcd-6.9.3/dev.h dhcpcd-6.9.3/dev/udev.c dhcpcd-6.9.3/dhcp-common.c dhcpcd-6.9.3/dhcp-common.h dhcpcd-6.9.3/dhcp.c dhcpcd-6.9.3/dhcp.h dhcpcd-6.9.3/dhcp6.c dhcpcd-6.9.3/dhcp6.h dhcpcd-6.9.3/dhcpcd-embedded.h.in dhcpcd-6.9.3/dhcpcd-run-hooks.8.in dhcpcd-6.9.3/dhcpcd.8.in dhcpcd-6.9.3/dhcpcd.c dhcpcd-6.9.3/dhcpcd.conf.5.in dhcpcd-6.9.3/dhcpcd.h dhcpcd-6.9.3/duid.c dhcpcd-6.9.3/duid.h dhcpcd-6.9.3/eloop.c dhcpcd-6.9.3/eloop.h dhcpcd-6.9.3/if-bsd.c dhcpcd-6.9.3/if-linux-wext.c dhcpcd-6.9.3/if-linux.c dhcpcd-6.9.3/if-options.c dhcpcd-6.9.3/if-options.h dhcpcd-6.9.3/if-sun.c dhcpcd-6.9.3/if.c dhcpcd-6.9.3/if.h dhcpcd-6.9.3/ipv4.c dhcpcd-6.9.3/ipv4.h dhcpcd-6.9.3/ipv4ll.c dhcpcd-6.9.3/ipv4ll.h dhcpcd-6.9.3/ipv6.c dhcpcd-6.9.3/ipv6.h dhcpcd-6.9.3/ipv6nd.c dhcpcd-6.9.3/ipv6nd.h dhcpcd-6.9.3/script.c dhcpcd-6.9.3/script.h dhcpcd-6.9.3/test/test.c dhcpcd-6.9.3/test/test.h dhcpcd-6.9.3/test/test_hmac_md5.c BSD (2 clause) ISC ------------------ dhcpcd-6.9.3/bpf-filter.h BSD (3 clause) -------------- dhcpcd-6.9.3/compat/queue.h ISC --- dhcpcd-6.9.3/compat/arc4random_uniform.c Unknown or generated -------------------- dhcpcd-6.9.3/GNUmakefile dhcpcd-6.9.3/Makefile dhcpcd-6.9.3/Makefile.inc dhcpcd-6.9.3/README dhcpcd-6.9.3/compat/arc4random.c dhcpcd-6.9.3/config-null.mk dhcpcd-6.9.3/configure dhcpcd-6.9.3/dev/Makefile dhcpcd-6.9.3/dhcpcd-definitions.conf dhcpcd-6.9.3/dhcpcd-embedded.c.in dhcpcd-6.9.3/dhcpcd-hooks/01-test dhcpcd-6.9.3/dhcpcd-hooks/02-dump dhcpcd-6.9.3/dhcpcd-hooks/10-wpa_supplicant dhcpcd-6.9.3/dhcpcd-hooks/15-timezone dhcpcd-6.9.3/dhcpcd-hooks/20-resolv.conf dhcpcd-6.9.3/dhcpcd-hooks/29-lookup-hostname dhcpcd-6.9.3/dhcpcd-hooks/30-hostname dhcpcd-6.9.3/dhcpcd-hooks/50-dhcpcd-compat dhcpcd-6.9.3/dhcpcd-hooks/50-ntp.conf dhcpcd-6.9.3/dhcpcd-hooks/50-yp.conf dhcpcd-6.9.3/dhcpcd-hooks/50-ypbind.in dhcpcd-6.9.3/dhcpcd-hooks/GNUmakefile dhcpcd-6.9.3/dhcpcd-hooks/Makefile dhcpcd-6.9.3/dhcpcd-run-hooks.in dhcpcd-6.9.3/dhcpcd.conf dhcpcd-6.9.3/genembedc dhcpcd-6.9.3/genembedh dhcpcd-6.9.3/iconfig.mk dhcpcd-6.9.3/test/GNUmakefile dhcpcd-6.9.3/test/Makefile [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/dhcpcd-hooks [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec/dhcpcd-hooks [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [!]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dhcpcd-6.9.3-2.fc24.i686.rpm dhcpcd-6.9.3-2.fc24.src.rpm dhcpcd.i686: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic dhcpcd.i686: W: spelling-error Summary(en_US) rdisc -> disc, r disc dhcpcd.i686: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic dhcpcd.i686: W: unstripped-binary-or-object /usr/sbin/dhcpcd dhcpcd.i686: E: non-standard-executable-perm /usr/libexec/dhcpcd-run-hooks 555 dhcpcd.i686: E: non-standard-executable-perm /usr/sbin/dhcpcd 555 dhcpcd.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic dhcpcd.src: W: spelling-error Summary(en_US) rdisc -> disc, r disc dhcpcd.src: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic dhcpcd.src: W: no-%build-section 2 packages and 0 specfiles checked; 2 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- INFO: mock.py version 1.2.13 starting (python version = 3.4.3)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.13 INFO: Mock Version: 1.2.13 Finish: chroot init INFO: installing package(s): rpmlint ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 24 install rpmlint Requires -------- dhcpcd (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig config(dhcpcd) libc.so.6 rtld(GNU_HASH) Provides -------- dhcpcd: config(dhcpcd) dhcpcd dhcpcd(x86-32) Source checksums ---------------- http://roy.marples.name/downloads/dhcpcd/dhcpcd-6.9.3.tar.xz : CHECKSUM(SHA256) this package : 6089471ed695fa62ac8351466b96b4b6365fd14ec455a120a6524663808eae53 CHECKSUM(SHA256) upstream package : 6089471ed695fa62ac8351466b96b4b6365fd14ec455a120a6524663808eae53 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -rvn dhcpcd-6.9.3-2.fc24.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ---------------------------------------------------------------- Well, 1. Checking for libudev ... no Checking for ntpd ... not found Checking for ypbind ... not found i. Systemd dev packages required. ---Attention--- 1. Make sure you have correct systemd scriptlets, it's important. 2. Make sure you have elegant systemd unit files, means it doesn't hurt user experience during upgrade. 3. Make sure you have units for all interfaces / single interface, this means you need to create dhcpcd.service and dhcpcd@.service. ii. Also consider adding ntp hook. 2. Where is build section? 3. EPEL7 doesn't requires Group tag. 4. dhcpcd.i686: E: non-standard-executable-perm /usr/libexec/dhcpcd-run-hooks 555 dhcpcd.i686: E: non-standard-executable-perm /usr/sbin/dhcpcd 555 Why not 755? Lying in /sbin doesn't mean 555 is OK. 5. Haven't specify dbdir in %configure, if you insist on keeping the default path, then include it in %files, by %ghost, %dir (mkdir in %install, then include it in %files, or other ways you like) 6. `make test` please. 7. %post -p /sbin/ldconfig %postun -p /sbin/ldconfig You are confusing yourself, ldconfig shouldn't be called because dhcpcd doesn't have libraries. 8. You need to make sure ipv4all and duid are disabled, for reasons behind: i. 0conf sucks ii. DHCP Unique Identifier sucks in many environments which don't have ipv6 enabled. 9. /etc -> %{_sysconfdir} in %files. ------------------------------ Just out of curiosity, have you ever used it? From the spec I couldn't parse, too opaque. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review