https://bugzilla.redhat.com/show_bug.cgi?id=1273712 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Issues: 1) if you run rpmlint on source rpm only then you will see google-noto-cjk-fonts.src: E: description-line-too-long C Noto Sans CJK is a sans serif typeface designed as an intermediate style between the modern and traditional. It is intended to be a multi-purpose digital font for user interface designs, digital content, reading on laptops, mobile devices, and electronic books. Noto Sans CJK comprehensively covers Simplified Chinese, Traditional Chinese, Japanese, and Korean in a unified font family. It supports regional variants of ideographic characters for each of the four languages. In addition, it supports Japanese kana, vertical forms, and variant characters (itaiji); it supports Korean hangeul — both contemporary and archaic. google-noto-cjk-fonts.src: W: no-version-in-last-changelog google-noto-cjk-fonts.src:81: E: use-of-RPM_SOURCE_DIR Fix these 3 issues. You need to split common_desc line to 80 char limit multiple lines. You missed the version in changelog then instead of sourcedir macro try builddir macro 2) removal of buildroot in %install, then %clean section are optional and can be removed. 3) I don't think it makes sense to create -common subpackage just for LICENSE file. Instead drop it and add %doc LICENSE to every binary rpm. 4) We need to follow git source guidelines. See https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services Add in spec at top %global commit0 40-CHARACTER-HASH-VALUE %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) then Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz and in %prep %setup -qn %{name}-%{commit0} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review