https://bugzilla.redhat.com/show_bug.cgi?id=1274496 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-SQL-Tokenizer-0.24-2.fc24.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(:VERSION) >= 5.6.2 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-SQL-Tokenizer-0.24-2.fc24.noarch.rpm | sort | uniq -c 1 perl(SQL::Tokenizer) = 0.24 1 perl-SQL-Tokenizer = 0.24-2.fc24 Binary provides are Ok. $ rpmlint ./perl-SQL-Tokenizer* perl-SQL-Tokenizer.src: W: spelling-error %description -l en_US verifier -> versifier, verifies, verified perl-SQL-Tokenizer.noarch: W: spelling-error %description -l en_US verifier -> versifier, verifies, verified 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok BuildRequires TODO: Constrain `perl(Test::Pod)' build-time dependency with `>= 1.14' (t/pod.t:5:) FIX: Please add following build-requires: - coreutils - perl-SQL-Tokenizer.spec:41 - findutils - perl-SQL-Tokenizer.spec:41 - make - perl-SQL-Tokenizer.spec:33 FIX: Please replace PERL_INSTALL_ROOT by DESTDIR Please correct all 'FIX' issues and consider fixing 'TODO' item Otherwise the package looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review