https://bugzilla.redhat.com/show_bug.cgi?id=1273244 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to gil cattaneo from comment #3) > NON blocking issues: > [?]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 10 files have unknown license. Detailed > output of licensecheck in /home/gil/1273244-gap-pkg- > grape/licensecheck.txt > Please, inform upstream > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification > Unknown or generated > -------------------- > grape/doc/cnauty.tex > grape/doc/colour.tex > grape/doc/consmod.tex > grape/doc/constr.tex > grape/doc/determin.tex > grape/doc/grape.tex > grape/doc/inspect.tex > grape/doc/manual.tex > grape/doc/partlin.tex > grape/doc/special.tex I don't think there is any need to inform upstream of this. The license is clearly spelled out in doc/grape.tex, which is the master LaTeX file, so the license ends up in the generated PDF. Furthermore, the license is listed in the actual source files, lib/grape.g and lib/smallestimage.g, as well as in the top-level files COPYING and gpl.txt, and also mentioned in README. > gap-pkg-grape.noarch: E: incorrect-fsf-address > /usr/lib/gap/pkg/grape/lib/grape.g > gap-pkg-grape.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-grape/gpl.txt > gap-pkg-grape.noarch: E: incorrect-fsf-address > /usr/lib/gap/pkg/grape/lib/smallestimage.g > Please, inform upstream > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Yes, this is endemic in the GAP community. I think that GAP itself started out with the wrong address, and then various authors of GAP addons copied the license file from GAP itself, and so now we've got the wrong address everywhere. Argh. I will certainly inform upstream of this issue. Thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review