https://bugzilla.redhat.com/show_bug.cgi?id=1272668 Jared Smith <jsmith.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsmith.fedora@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jsmith.fedora@xxxxxxxxx Flags| |fedora-review? CC| |piotr1212@xxxxxxxxx Flags| |needinfo?(piotr1212@gmail.c | |om) --- Comment #1 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- A few comments (that also apply to some of your other outstanding package requests for nodejs-packages): 1. Use tarballs from the NPM registry. See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Using_tarballs_from_the_npm_registry Please note that the RPM registry tarballs don't contain the tests, so you'll need to pull them separately. Since the test is a single file, you can simply grab it like this: %{?nodejs_find_provides_and_requires} %global packagename arrify %global github_tag_hash 4576e944677c722c356480b17a6d709d34d0733c %global enable_tests 0 # Tests are disabled until 'ava' is packaged in Fedora # See https://bugzilla.redhat.com/show_bug.cgi?id=1194923 Name: nodejs-arrify Version: 1.0.0 Release: 1%{?dist} Summary: Convert a value to an array License: MIT URL: https://github.com/sindresorhus/arrify Source0: https://registry.npmjs.org/%{packagename}/-/%{packagename}-%{version}.tgz # npm registry doesn't contain tests, so get the test file from the github repo Source1: https://raw.githubusercontent.com/sindresorhus/arrify/%{github_tag_hash}/test.js 2. Your %check section should use the testing method specified in the package.json file. In this case, you wouldn't run mocha, but instead run /usr/bin/node test.js 3. In your %files section, you can add the following line (directly below the %files line) so that the same spec file can be used in EPEL6, where there is no %license macro: %{!?_licensedir:%global license %doc} Please fix those three items, and I'll do the formal package review on this and the other dependencies for 'ava'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review