[Bug 1273874] Review Request: nodejs-balanced-match - Match balanced character pairs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1273874

Troy Dawson <tdawson@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #2 from Troy Dawson <tdawson@xxxxxxxxxx> ---
- Please ask upstream to provide a separate license file.  They do have the
full license in the README.md, but it would still be nice to have it separate.
- It looks like the test requires the older tape, like others you've done.  Can
you please put that as a comment up at %global enable_tests 0, similar to some
of your other packages.

Both of those things are minor and everything else looks good.

Package Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]